Renamed Cheshvan to Marcheshvan#241
Closed
CompuGeniusCode wants to merge 1 commit intoKosherJava:masterfrom
Closed
Renamed Cheshvan to Marcheshvan#241CompuGeniusCode wants to merge 1 commit intoKosherJava:masterfrom
CompuGeniusCode wants to merge 1 commit intoKosherJava:masterfrom
Conversation
Owner
|
@CompuGeniusCode , I addressed this by allowing overriding the array of Hebrew month names. See ed7a821. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Besides wanting the proper name, I also see that you mentioned wanting to fix it here: #131 (review)
Pretty sure I got all the places it was spelled incorrectly. I also renamed function names, so you may want to only accept the string changes now and wait for the functions in a new breaking release, but that's up to you.